Skip to content

"Copy As" does not work on an opcode token #5189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bb33bb opened this issue Mar 16, 2024 · 3 comments
Closed

"Copy As" does not work on an opcode token #5189

bb33bb opened this issue Mar 16, 2024 · 3 comments
Assignees
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Bug Issue is a non-crashing bug with repro steps
Milestone

Comments

@bb33bb
Copy link

bb33bb commented Mar 16, 2024

Version and Platform (required):

Binary Ninja Version: 4.1.4963-dev Personal (a066b74f)
OS: manjaro
OS Version: Linux version 6.6.19-1-MANJARO (builduser@fv-az1021-257) (gcc (GCC) 13.2.1 20230801, GNU ld (GNU Binutils) 2.42.0) #1 SMP PREEMPT_DYNAMIC Fri Mar 1 18:16:16 UTC 2024
CPU Architecture: x64

Bug Description:
no difference between copying big Endian or Little Endian

Steps To Reproduce:
just check the video:

simplescreenrecorder-2024-03-17_01.00.58.mp4

Expected Behavior:
big Endian is different from Little Endian

@plafosse
Copy link
Member

Work around: Select the line rather than the token on the line and that should work as expected.
Whats happening here is that you're copying the token instead of the bytes. Our fix for this will be to disable copy as big/little endian when a token is selected rather than a byte range.

@plafosse plafosse changed the title no difference between copying big Endian or Little Endian Disable Copying as big/little Endian when a token is selected Mar 19, 2024
@plafosse plafosse added Type: Bug Issue is a non-crashing bug with repro steps Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround labels Mar 19, 2024
@xusheng6 xusheng6 self-assigned this Mar 20, 2024
@xusheng6
Copy link
Member

I actually did not disable the "Copy As" action on an opcode token. And it should now work as expected with the above fix

@xusheng6 xusheng6 changed the title Disable Copying as big/little Endian when a token is selected "Copy As" does not work on an opcode token Mar 20, 2024
@xusheng6 xusheng6 added this to the Elysium milestone Mar 20, 2024
@xusheng6
Copy link
Member

Fixed in dev 4.1.4972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Bug Issue is a non-crashing bug with repro steps
Projects
None yet
Development

No branches or pull requests

3 participants