Skip to content

Commit 2c15658

Browse files
committed
feat: Delete FramesEncodedSentIssueDetector
1 parent de773e4 commit 2c15658

File tree

4 files changed

+0
-100
lines changed

4 files changed

+0
-100
lines changed

README.md

-17
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ By default, WebRTCIssueDetector can be created with minimum of mandatory constru
5151
```typescript
5252
import WebRTCIssueDetector, {
5353
QualityLimitationsIssueDetector,
54-
FramesEncodedSentIssueDetector,
5554
InboundNetworkIssueDetector,
5655
OutboundNetworkIssueDetector,
5756
NetworkMediaSyncIssueDetector,
@@ -68,7 +67,6 @@ const widWithDefaultConstructorArgs = new WebRTCIssueDetector();
6867
const widWithCustomConstructorArgs = new WebRTCIssueDetector({
6968
detectors: [ // you are free to change the detectors list according to your needs
7069
new QualityLimitationsIssueDetector(),
71-
new FramesEncodedSentIssueDetector(),
7270
new InboundNetworkIssueDetector(),
7371
new OutboundNetworkIssueDetector(),
7472
new NetworkMediaSyncIssueDetector(),
@@ -121,21 +119,6 @@ const exampleIssue = {
121119
}
122120
```
123121

124-
### FramesEncodedSentIssueDetector
125-
Detects issues with outbound network throughput.
126-
```js
127-
const exampleIssue = {
128-
type: 'network',
129-
reason: 'outbound-network-throughput',
130-
statsSample: {
131-
deltaFramesSent: 900,
132-
deltaFramesEncoded: 1000,
133-
missedFramesPct: 10,
134-
},
135-
ssrc: 1234,
136-
}
137-
```
138-
139122
### InboundNetworkIssueDetector
140123
Detects issues with inbound network connection.
141124
```js

src/WebRTCIssueDetector.ts

-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import PeriodicWebRTCStatsReporter from './parser/PeriodicWebRTCStatsReporter';
1717
import DefaultNetworkScoresCalculator from './NetworkScoresCalculator';
1818
import {
1919
AvailableOutgoingBitrateIssueDetector,
20-
FramesEncodedSentIssueDetector,
2120
InboundNetworkIssueDetector,
2221
NetworkMediaSyncIssueDetector,
2322
OutboundNetworkIssueDetector,
@@ -60,7 +59,6 @@ class WebRTCIssueDetector {
6059

6160
this.detectors = params.detectors ?? [
6261
new QualityLimitationsIssueDetector(),
63-
new FramesEncodedSentIssueDetector(),
6462
new InboundNetworkIssueDetector(),
6563
new OutboundNetworkIssueDetector(),
6664
new NetworkMediaSyncIssueDetector(),

src/detectors/FramesEncodedSentIssueDetector.ts

-80
This file was deleted.

src/detectors/index.ts

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
export { default as BaseIssueDetector } from './BaseIssueDetector';
22
export { default as AvailableOutgoingBitrateIssueDetector } from './AvailableOutgoingBitrateIssueDetector';
3-
export { default as FramesEncodedSentIssueDetector } from './FramesEncodedSentIssueDetector';
43
export { default as InboundNetworkIssueDetector } from './InboundNetworkIssueDetector';
54
export { default as NetworkMediaSyncIssueDetector } from './NetworkMediaSyncIssueDetector';
65
export { default as OutboundNetworkIssueDetector } from './OutboundNetworkIssueDetector';

0 commit comments

Comments
 (0)