Skip to content

Some enhancements #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 23, 2022
Merged

Some enhancements #78

merged 11 commits into from
Sep 23, 2022

Conversation

xepozz
Copy link
Contributor

@xepozz xepozz commented Sep 22, 2022

  • Set horizontal margin 1px on each side. The condition was always true
  • Change is return type to boolean
  • A few cosmetic changes

@netlify
Copy link

netlify bot commented Sep 22, 2022 •
edited
Loading

✅ Deploy Preview for any-viewer ready!

Name Link
🔨 Latest commit 4d88344
🔍 Latest deploy log https://app.netlify.com/sites/any-viewer/deploys/632d64adc7a7a4000828157c
😎 Deploy Preview https://deploy-preview-78--any-viewer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@xepozz xepozz changed the title Refactor Some enhancements Sep 22, 2022
@codecov
Copy link

codecov bot commented Sep 22, 2022 •
edited
Loading

Codecov Report

Base: 89.47% // Head: 89.38% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (4d88344) compared to base (b2ea339).
Patch coverage: 95.65% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   89.47%   89.38%   -0.09%     
==========================================
  Files          18       18              
  Lines        1777     1781       +4     
  Branches      240      239       -1     
==========================================
+ Hits         1590     1592       +2     
- Misses        187      189       +2
Impacted Files Coverage Δ
src/hooks/useInspect.ts 87.71% <90.00%> (-3.19%) ⬇️
src/components/DataKeyPair.tsx 77.28% <100.00%> (+0.33%) ⬆️
src/components/DataTypes/Object.tsx 86.10% <100.00%> (-0.11%) ⬇️
src/stores/typeRegistry.tsx 94.70% <100.00%> (ø)
src/type.ts 100.00% <100.00%> (ø)
src/utils/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

himself65
himself65 reviewed Sep 23, 2022
View reviewed changes
src/components/DataTypes/Object.tsx Outdated
@@ -65,7 +65,7 @@ export const PreObjectType: React.FC<DataItemProps<object>> = (props) => {
<CircularArrowsIcon sx={{
fontSize: 12,
color: textColor,
mx: sizeOfValue ? 0.5 : 0
mx: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this cause the icon too wide? I'm not a UI designer not sure which is better

Screenshot from 2022-09-22 19-37-20

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decreased to 0.5 that means 4px on each side (I hope :))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap. That's better.

@himself65 himself65 merged commit 46e1c68 into TexteaInc:main Sep 23, 2022
@github-actions github-actions bot mentioned this pull request Sep 23, 2022
Merged
@xepozz xepozz deleted the refactor branch September 23, 2022 13:38
Yazawazi pushed a commit that referenced this pull request Mar 10, 2023
@xepozz
fix: some enhancements (#78)
25b23eb
@github-actions github-actions bot mentioned this pull request Oct 9, 2023
Closed
@github-actions github-actions bot mentioned this pull request Apr 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xepozz @himself65