Skip to content

Simplify ifs #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Simplify ifs #70

merged 1 commit into from
Sep 22, 2022

Conversation

xepozz
Copy link
Contributor

@xepozz xepozz commented Sep 22, 2022

There is no need to use else if in previous if was return instruction. It enhances reading at least.

@netlify
Copy link

netlify bot commented Sep 22, 2022

Deploy Preview for any-viewer ready!

Name Link
🔨 Latest commit e39d031
🔍 Latest deploy log https://app.netlify.com/sites/any-viewer/deploys/632ccbb90eb31b00085f790b
😎 Deploy Preview https://deploy-preview-70--any-viewer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 89.77% // Head: 89.70% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (e39d031) compared to base (044b493).
Patch coverage: 94.11% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   89.77%   89.70%   -0.08%     
==========================================
  Files          18       18              
  Lines        1780     1777       -3     
  Branches      244      243       -1     
==========================================
- Hits         1598     1594       -4     
- Misses        182      183       +1     
Impacted Files Coverage Δ
src/components/DataKeyPair.tsx 78.43% <80.00%> (-0.67%) ⬇️
src/components/DataTypes/Object.tsx 86.20% <100.00%> (-0.16%) ⬇️
src/stores/typeRegistry.tsx 94.70% <100.00%> (+0.29%) ⬆️
src/utils/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 merged commit b2ea339 into TexteaInc:main Sep 22, 2022
@xepozz xepozz deleted the simplify-ifs branch September 22, 2022 21:45
Yazawazi pushed a commit that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants