Skip to content

fix: correct types reference for module projects #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

TSmota
Copy link
Contributor

@TSmota TSmota commented Jan 24, 2023

There is an incorrect reference in the package.json as the src folder is not published to npm, which gives an error when using it inside a project with type: module

Could not find a declaration file for module '@textea/json-viewer'. 'D:/DEV/DEVOPS/gerald/node_modules/@textea/json-viewer/dist/index.mjs' implicitly has an 'any' type.

@netlify
Copy link

netlify bot commented Jan 24, 2023

Deploy Preview for any-viewer ready!

Name Link
🔨 Latest commit 07413c4
🔍 Latest deploy log https://app.netlify.com/sites/any-viewer/deploys/63d03fdbd9282a0009263a01
😎 Deploy Preview https://deploy-preview-219--any-viewer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@TSmota TSmota changed the title Fix: correct types reference Fix: correct types reference for module projects Jan 24, 2023
Copy link
Collaborator

@pionxzh pionxzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pionxzh pionxzh changed the title Fix: correct types reference for module projects fix: correct types reference for module projects Jan 25, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 87.40% // Head: 87.40% // No change to project coverage 👍

Coverage data is based on head (07413c4) compared to base (7884a29).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   87.40%   87.40%           
=======================================
  Files          18       18           
  Lines        1969     1969           
  Branches      349      349           
=======================================
  Hits         1721     1721           
  Misses        248      248           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants