Show three dots only on collapsed strings #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for any-viewer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks for the contribution |
Codecov ReportBase: 87.42% // Head: 87.42% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 87.42% 87.42%
=======================================
Files 18 18
Lines 1892 1892
Branches 308 308
=======================================
Hits 1654 1654
Misses 238 238
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a string is collapsed, it always shows the three dots (...) at the end in both states, collapsed and uncollapsed.
This PR should fix this behaviour.
(Unfortunately I'm unable to test this locally. I'm unable get this project up and running. I can build the sources with 'yarn && yarn build', but when I add it to another project (even a fresh create-react-app) I got errors 'Invalid hook call. Hooks can only be called inside of the body of a function component.' and 'Uncaught TypeError: Cannot read properties of null (reading 'useMemo')'. I'm sorry, my skills end here.)