Skip to content

Commit 1099c05

Browse files
vijaytalupulaSapphicFire
vijaytalupula
and
SapphicFire
authored
Created a new instance scan check (Table Check) & Updated the README.md document. (#180)
* Created a new instance scan checks (Table Check). * Update README.md --------- Co-authored-by: Astrid Sapphire <[email protected]>
1 parent 222d40a commit 1099c05

File tree

3 files changed

+58
-1
lines changed

3 files changed

+58
-1
lines changed

Diff for: ‎README.md

+5
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,11 @@ Tickets from tables such as Incident, Change Request, Problem, and other task-re
179179
### Check Inactive Business Rules over 90 days
180180
Inactive Business Rules which are not updated for more than 90 days and not created by glide.maint and not updated by admin should be identified to remove unnecessary overhead.
181181

182+
### Update set In Progress/Completed previously Ignored
183+
Usually, developers mark an updatesets as Ignore if the work done is not required to be promoted or incorrect or irrelavent or due to any other reasons.
184+
However, at times, some of the developers may use the ignored set for any active work instead of creating new one by updating the state from Ignore to In-Progress. It is not a good practice to do the same. It may case the deployment issues and also makes the troubleshooting process cumbersome.
185+
It may also impact the deployment and cause issues in case if the state is changed to In-Progress/Completed for the potential ignored sets.
186+
182187
## Category: Upgradability
183188

184189
### Call GlideRecord using new

Diff for: ‎ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
g3fOXFKd_SJhY9hj5S6s3duX-d8QXo-aSq9DmLRSggO5QMR75a3S7veyxd7UW-55ROSZ3KZjkORvxDYC4eAoUw8hM5sBWzpif0rXl-I8pW_VUCIh6epUd3BCmn83iXPR1-OT_yZ9dFtlQN97LDs2GL0KQjct68x8NHekh9tYbFUjuQUBI_KuJJ0K9Vb1BgVtLHwuTloIyflunbMQLgcrSSCxSC_INduOiWNzlFF2AFYjlcv8I4JjPpaFDCHCcaPGYHUmAVfsjTiBx3owim2ZBkmIBrQmCDl3m8sqmnfrGXsU-FDAXaMghtw5gFVdQt1vsqnZmW16o7TGnwo6I7w4q8h37ATVhuwgCA_rUAI6ckPtO9uBWYLC7AJX3X2P2emhszEC2sQwmy17Ul9guViUL4LIA4LpeuG6virKuq8nUJne6mrzciepOadDXUVYriNwLjTWy9qlIhIgpaD1wv0MckKAJ1vx_io6bROOgr3xgI3p717PF6RYfnUoS57_l5IuKfCVaFNHDA0VO0x8o9_B0aq3HHJksOnbeLFNSEdIm5_dK32KOcxzWKa5NYIqDimQqQvAvTnhqucdsENG6K8G3Olw1auQYgIu5J3s0RHxY52Nn3Zx7wCFFJXSLpKeU6T-E3M9JHF_nAa3s-FUWwuvCZL_38uyxhcKSBCFDOsN_Rg
1+
uEH-MVj5358yRx1qNhQZQDDN5DRl_EHSvw3CQ3-uqkJ_UjcZdANraoCdU5KL_mwp7x_66jQSj054ighy53LegM7d6xp8_kOx-SoZTIBBtdf3RE1OwevZASv1Xl2dR1lp0CM5i8lVq4rGQFmN2RkUv1xgprPYKTBCZ4CamesJX89wF4nSGzRdUqPHkH_e73S8Jgwmmm4BxHZ0ow4yyQ3QJbAu90kHsbyehFpjxnzDPjiml_OPVkwylOkpqn4QviJ4UAcgb-00eYvr7RSYX2blyPTisybSLuK2ty0jsylJC8xzt5ZuO5ronXCrqPIwN2P9yXqU-nP3xnCZJJXnSGV2xUU-5OkcoMrfEht5HOM39kIOxzzJvGAOXs6wGA7OqEDdoZHQeZL3eR9m6lq_nHMCHPYjl8nFUedj10VV3oF6YETA4MX0MGNrybGVxIFfibgbqAzLnwiUnfKRtdvF3kRpcIBn8WGEiiSSzDDXovB4gY1b8Fhkk8SNhAM8a9518wFfJRbCWj4kwIJRbbKOKmOf1PY31VjHy8tQ0FH8xALm4sbGHfDTgGdo-Cjy3Velkrr3nqFJJOpdpqB1-I4_fXl8clJPYUou8CdxBhc9bhuZbkJvggMU-8Ne18HimH3K9cn2OLyRe7gRi8-nfG8c-pzvY_gW6iYdD3Yvdfqtirxs6gw

Diff for: ‎ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_01c1c08ec3a19610afa6fc84e401310d.xml

+52
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
2+
<scan_table_check action="INSERT_OR_UPDATE">
3+
<active>true</active>
4+
<advanced>true</advanced>
5+
<category>manageability</category>
6+
<conditions table="sys_update_set">state=in progress^ORstate=complete^EQ<item display_value="In progress" endquery="false" field="state" goto="false" newquery="false" operator="=" or="false" value="in progress"/>
7+
<item display_value="Complete" endquery="false" field="state" goto="false" newquery="false" operator="=" or="true" value="complete"/>
8+
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
9+
</conditions>
10+
<description>Usually, developers mark an updatesets as Ignore if the work done is not required to be promoted or incorrect or irrelavent or due to any other reasons.
11+
However, at times, some of the developers may use the ignored set for any active work instead of creating new one by updating the state from Ignore to In-Progress. It is not a good practice to do the same. It may case the deployment issues and also makes the troubleshooting process cumbersome.
12+
It may also impact the deployment and cause issues in case if the state is changed to In-Progress/Completed for the potential ignored sets.</description>
13+
<documentation_url/>
14+
<finding_type>scan_finding</finding_type>
15+
<name>Update set In Progress/Completed previously Ignored</name>
16+
<priority>3</priority>
17+
<resolution_details>It is always good and recommended to create a new updateset instead of using already Ignored updatesets by changing the state from Ignore to In-Progress/Completed.</resolution_details>
18+
<run_condition/>
19+
<score_max>100</score_max>
20+
<score_min>0</score_min>
21+
<score_scale>1</score_scale>
22+
<script><![CDATA[(function (finding, current) {
23+
24+
var usSysId = current.getUniqueValue();
25+
var audit = new GlideRecord('sys_audit');
26+
audit.addEncodedQuery('fieldname=state^tablename=sys_update_set^oldvalue=ignore^newvalue=in progress^ORnewvalue=complete');
27+
audit.addQuery('documentkey', usSysId);
28+
audit.setLimit(1);
29+
audit.query();
30+
31+
if(audit.hasNext()){
32+
finding.increment();
33+
}
34+
35+
})(finding, current);]]></script>
36+
<short_description>Already Ignored Update Set shouldn't be set back to In Pogress/Completed.</short_description>
37+
<sys_class_name>scan_table_check</sys_class_name>
38+
<sys_created_by>admin</sys_created_by>
39+
<sys_created_on>2024-10-30 19:28:34</sys_created_on>
40+
<sys_id>01c1c08ec3a19610afa6fc84e401310d</sys_id>
41+
<sys_mod_count>0</sys_mod_count>
42+
<sys_name>Update set In Progress/Completed previously Ignored</sys_name>
43+
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
44+
<sys_policy/>
45+
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
46+
<sys_update_name>scan_table_check_01c1c08ec3a19610afa6fc84e401310d</sys_update_name>
47+
<sys_updated_by>admin</sys_updated_by>
48+
<sys_updated_on>2024-10-30 19:28:34</sys_updated_on>
49+
<table>sys_update_set</table>
50+
<use_manifest>false</use_manifest>
51+
</scan_table_check>
52+
</record_update>

0 commit comments

Comments
 (0)