-
Notifications
You must be signed in to change notification settings - Fork 191
Add GitHub Reactions support #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Reactions support #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for starting this effort!
I haven't had a chance to review the tests yet. I'll do so shortly. In the meantime, I have some comments for you to review and address in the code.
Nice job with adding in pipeline support! I'm still mulling over the idea of PassThru
and the implications that would have for the rest of the module.
Thanks -- will give a final pass at this tomorrow, and then hopefully get it merged in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor nits, then ready to go. Will kick off CI in the meantime.
/azp run PowerShellForGitHub-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run PowerShellForGitHub-CI |
Commenter does not have sufficient privileges for PR 193 in repo microsoft/PowerShellForGitHub |
Now that #242 is in, we have a standard way for handling the pipeline throughout the module. Are you willing to update this PR to adopt it? Thanks. |
Co-authored-by: Howard Wolosky <[email protected]>
Co-authored-by: Howard Wolosky <[email protected]>
43dcb38
to
77203bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update and getting this aligned with the rest of the module's pipeline support after #242. Looks like there just a few more updates to make before this is ready to go in.
/azp run PowerShellForGitHub-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run PowerShellForGitHub-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
any thoughts? |
I was waiting for you to post an update removing the comments support just for this PR so that we could get it in. Then we can work through a good design to add back the comments support. That keeps a good code flow going without having this PR specifically grow and grow and grow. |
removed |
/azp run PowerShellForGitHub-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
@HowardWolosky I don't think I impacted these failures |
Agreed -- there's some instability in a couple of the Repository tests that need to be investigated, but those are not considered blocking for getting this in. This should get merged today, and then we can work on adding-in comment support. |
PowerShellForGitHub.psd1
Outdated
# HelpInfo URI of this module | ||
# HelpInfoURI = '' | ||
} | ||
# Copyright (c) Microsoft Corporation. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TylerLeonhardt - Can you take a quick look at this file? It looks like the whole file changed. Likely an encoding issue. Would be great if you could get it updated in the PR such that it reflects just the changed lines. Might require you to revert the file and then re-apply the changes. I've noticed that using the GitHub web resolver does this to the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks for this!
This adds the following cmdlets:
Get-GitHubReaction
- https://developer.github.com./v3/reactions/#list-reactions-for-an-issueSet-GitHubReaction
- https://developer.github.com./v3/reactions/#create-reaction-for-an-issueRemove-GitHubReaction
- https://developer.github.com./v3/reactions/#delete-an-issue-reactionThe
Get
andSet
can pipe intoRemove
Get-GitHubIssue
can pipe intoGet
andSet-GitHubReaction
I also added some tests.
NOTE: commit comments will come later.
NOTE: DO NOT REMOVE THESE REACTIONS THEY ARE USED IN A TEST: