Skip to content

handle_final_shape_cb argument doesn't work on MultilineTool, PolygonTool, AnnotatedPolygonTool #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imad-miftek opened this issue Jan 26, 2025 · 1 comment

Comments

@imad-miftek
Copy link

The handle_final_shape_cb argument on the AnnotatedPolygonTool does not call the callback function set to it. I can't get the shape object once the tool helps create the final shape.

The handle_final_shape_cb works as expected in the AnnotatedRectangleTool, and AnnotatedEllipseTool.

@PierreRaybaut PierreRaybaut changed the title handle_final_shape_cb argument doesn't work on AnnotatedPolygonTool handle_final_shape_cb argument doesn't work on MultilineTool, PolygonTool, AnnotatedPolygonTool Jan 26, 2025
@PierreRaybaut
Copy link
Contributor

PierreRaybaut commented Jan 26, 2025

Thanks for the feedback.
Actually the handle_final_shape_cb argument doesn't work on all tools deriving from MultilineTool.
This is a regression.
This is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants