Skip to content

Workspace library folder locked #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FlashHit opened this issue Jan 29, 2022 · 2 comments
Closed

Workspace library folder locked #934

FlashHit opened this issue Jan 29, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@FlashHit
Copy link

but the issue is that when you specify a workspace library folder for his extension, it locks that directory. So if you want to delete or move the directory, you can't

rejected promise not handled within 1 second: Error: EBUSY: resource busy or locked, rmdir 'e:\code\vscode-lua-testmod\.vu\intermediate\Shared'
c:\Users\scrap\AppData\Local\Programs\Microsoft VS Code\resources\app\out\bootstrap-fork.js:5
stack trace: Error: EBUSY: resource busy or locked, rmdir 'e:\code\vscode-lua-testmod\.vu\intermediate\Shared'
c:\Users\scrap\AppData\Local\Programs\Microsoft VS Code\resources\app\out\bootstrap-fork.js:5
@Imposter
Copy link

Imposter commented Jan 29, 2022

Just want to step in here and add some details to set the context. I maintain the Vua extension which utilizes your Lua extension under the hood.

We utilize a workspace with three folders which contain separate Lua code (and as such, each have an instance of the language server running). The problem occurs when we set a Workspace Library in the vscode/settings.json in the individual folders. The Vua extension has the ability to update the libraries while VS code is running and deletes/renames directories that are added to Lua.workspace.library. I recall this working fine a few months ago, but now when we delete the workspace library while the language server is running, we get the error that @FlashHit shared above.

It seems the language server is locking workspace libraries which prevent us from modifying them.

@sumneko sumneko added the bug Something isn't working label Feb 8, 2022
@sumneko
Copy link
Collaborator

sumneko commented Feb 10, 2022

fixed by 9908df0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants