EmmyLua definitions not recognized in Lua Language Server v2.4.10

[Feez]

Describe the bug
EmmyLua declarations are not recognized anymore

This has only started occurring on version 2.4.10. Works otherwise on 2.4.9 and below.

To Reproduce
Steps to reproduce the behavior:

v2.4.9:

v2.4.10:

main.lua:

local definitions = require("definitions")

---@type MyType
local a

a:GetSomething()

definitions.lua:

local MyTypeTbl = {}

---@class MyType
function MyTypeTbl:init()
end

function MyTypeTbl:GetSomething()
    return 1
end

return {
    MyTypeTbl = MyTypeTbl
}

Expected behavior
Language server recognizes the EmmyLua type and the functions defined on it.

Environment (please complete the following information):
Version: 1.62.3 (system setup)
Commit: ccbaa2d27e38e5afa3e5c21c1c7bef4657064247
Date: 2021-11-17T08:11:14.551Z
Electron: 13.5.2
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19042

(Not remote)

Provide logs
Not sure if applicable, but log - https://pastebin.com/raw/29uYg7jN

[sumneko]

Should be

---@class MyType
local MyTypeTbl = {}

function MyTypeTbl:init()
end

function MyTypeTbl:GetSomething()
    return 1
end

return {
    MyTypeTbl = MyTypeTbl
}

Related to: #806

[Feez]

@sumneko Still seems to occur on 2.4.11 if the fix is intended to be in there

[sumneko]

You need to rewrite your code to

---@class MyType
local MyTypeTbl = {}

function MyTypeTbl:init()
end

function MyTypeTbl:GetSomething()
    return 1
end

return {
    MyTypeTbl = MyTypeTbl
}

[Feez]

Ah, I see. Perhaps an error message or some type of diagnosis indicator to indicate this issue for any others that might be relying on this behavior from previous versions?

[sumneko]

Ah, I see. Perhaps an error message or some type of diagnosis indicator to indicate this issue for any others that might be relying on this behavior from previous versions?

When I am free, I will add more diagnostics related to LuaDoc.
In fact, this way of writing was wrong before, but there was another bug that happened to make it work. The basic principle of that bug is:

-- this is a bug that has fixed in 2.4.10

---@class A
function mt:init(x, y)
    print(x) -- `x` is A
    print(y) -- `y` is A
    print(self) -- `self` is A, `mt` can be inferred by `self` so `mt` is A
end