feat(completion): truncate arguments for callSnippet #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callSnippet always expands all the optional arguments and variable argument that is annoying. To truncate optional arguments and variable arguments help users more frequently use `callSnippet`. We already have the label and signature to get the total arguments. This behavior is like tsserver.
|
Found a bug about optional arguments is not continuous, needs to be fixed. |
If the arguments are all optional or variable until the end, we can truncate them directly.
|
I don't quite understand your requirements. Can you add some tests to make me understand your changes? |
|
I have tested under the below code: --- Test
---@param a number
---@param b? number
---@param c? number
---@vararg number
local function foo(a, b, c, ...) end
-- type `foo`You can change the arguments optional status to quickly check out the logic that is like tsserver. |
|
OK, I need time to explore the test framework. BTW, it's too late and it's time to sleep now. o_o |
Thank you, have a nice dream! |
|
Please review the code and share your idea. :) |
|
It make sense, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callSnippet always expands all the optional arguments and variable
argument that is annoying.
To truncate optional arguments and variable arguments help users more
frequently use
callSnippet. We already have the label and signature to getthe total arguments.
This behavior is like tsserver.