Skip to content

Commit d5a3c62

Browse files
committed
don't crash due to unknown response id
fix #1808
1 parent c44a0ca commit d5a3c62

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

changelog.md

+2
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,14 @@
1313
* `FIX` [#1737]
1414
* `FIX` [#1751]
1515
* `FIX` [#1767]
16+
* `FIX` [#1808]
1617

1718
[#831]: https://github.com./sumneko/lua-language-server/issues/831
1819
[#1729]: https://github.com./sumneko/lua-language-server/issues/1729
1920
[#1737]: https://github.com./sumneko/lua-language-server/issues/1737
2021
[#1751]: https://github.com./sumneko/lua-language-server/issues/1751
2122
[#1767]: https://github.com./sumneko/lua-language-server/issues/1767
23+
[#1808]: https://github.com./sumneko/lua-language-server/issues/1808
2224

2325
`2022-11-29`
2426
## 3.6.4

script/proto/proto.lua

+8-2
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,10 @@ function m.response(id, res)
5454
log.error('Response id is nil!', inspect(res))
5555
return
5656
end
57-
assert(m.holdon[id])
57+
if not m.holdon[id] then
58+
log.error('Unknown response id!', id)
59+
return
60+
end
5861
m.holdon[id] = nil
5962
local data = {}
6063
data.id = id
@@ -67,7 +70,10 @@ function m.responseErr(id, code, message)
6770
log.error('Response id is nil!', inspect(message))
6871
return
6972
end
70-
assert(m.holdon[id])
73+
if not m.holdon[id] then
74+
log.error('Unknown response id!', id)
75+
return
76+
end
7177
m.holdon[id] = nil
7278
m.send {
7379
id = id,

0 commit comments

Comments
 (0)