Skip to content

Using faces to index into point vectors no longer produces point vectors #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kevin-Mattheus-Moerman opened this issue Mar 7, 2025 · 2 comments · Fixed by #246
Closed

Comments

@Kevin-Mattheus-Moerman
Copy link
Contributor

Kevin-Mattheus-Moerman commented Mar 7, 2025

When for verion >=5.0 we have:

V = Point{3, Float64}[[-1.0, -1.0, -1.0], [-1.0, 1.0, -1.0], [1.0, 1.0, -1.0], [1.0, -1.0, -1.0]]
f = QuadFace{Int64}(1,2,3,4)

Then requesting:

V[f]

Now produces:
Quadrilateral([-1.0, -1.0, -1.0], [-1.0, 1.0, -1.0], [1.0, 1.0, -1.0], [1.0, -1.0, -1.0])

The original (when my compat read: GeometryBasics = "0.3, 0.4") and expected behaviour should return:

4-element StaticArraysCore.SVector{4, Point{3, Float64}} with indices SOneTo(4):
 [-1.0, -1.0, -1.0]
 [-1.0, 1.0, -1.0]
 [1.0, 1.0, -1.0]
 [1.0, -1.0, -1.0]
@Kevin-Mattheus-Moerman
Copy link
Contributor Author

@SimonDanisch is the above intentional? It breaks a lot of things in Comodo, I use faces/elements are indices into the point vectors quite often.

@Kevin-Mattheus-Moerman
Copy link
Contributor Author

@ffreyer just updated the above. The correct behaviour should return a Static vector while the "new" behaviour returns a Quadrilateral (or Triangle if TriangleFace is used).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant