Skip to content

Nicer domain for the book #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spier opened this issue Dec 23, 2020 · 8 comments
Closed

Nicer domain for the book #250

spier opened this issue Dec 23, 2020 · 8 comments
Labels
(Self-) Hosting Everything around artifact rendering and presentation.

Comments

@spier
Copy link
Member

spier commented Dec 23, 2020

Currently the URLs of our InnerSourcePatterns book look like this:

gitbook does allow us to configure a Custom Domain.

A custom domain could look like this:

If we configure books.innersourcecommons.org, then the URLS would change like this:

  • book landing page at books.innersourcecommons.org/innersource-patterns
  • individual patterns at books.innersourcecommons.org/innersource-patterns/patterns/innersource-portal

While the URLs in this proposal are not much shorter than the current URLs, the approach would have some advantages:

  • SEO for innersourcecommons.org (all keywords in our patterns drive traffic to innersourcecommons.org)
  • more clear affiliation of the InnerSourcePatterns book with the InnerSource Commons
  • the approach is extendable with new books? e.g. say we wanted to port https://dicortazar.gitbook.io/managing-inner-source-projects/, this would get the URL books.innersourcecommons.org/managing-inner-source-projects

Things that I don't like about the new URLs (somewhat unrelated to the custom domain topic actually):

  • books.innersourcecommons.org/innersource-patterns/patterns/innersource-portal contains patterns too often :) We could potentially move all pattern files one level up so that the URLs would be books.innersourcecommons.org/innersource-patterns/innersource-portal instead.

What do people thing? Other ideas for a custom domains?

@spier spier added the (Self-) Hosting Everything around artifact rendering and presentation. label Dec 23, 2020
@spier
Copy link
Member Author

spier commented Dec 25, 2020

I reviewed gitbook's configuration options for custom domains again.

If I understand the instruction's correctly, then gitbook offers theres 2 general options:

a) a sub-domain just for the patterns book (called space domain)

  • book landing page at patterns.innersourcecommons.org
  • individual patterns at patterns.innersourcecommons.org/patterns/innersource-portal

Note: I believe that in this configuration the project-id, "innersource-patterns" in our case, won't be part of the URL.

b) a sub-domain for all books that we host in our gitbook organization (called organizational domain)

  • book landing page at books.innersourcecommons.org/innersource-patterns
  • individual patterns at books.innersourcecommons.org/innersource-patterns/patterns/innersource-portal

@markdav-is
Copy link

I like this option: book landing page at patterns.innersource.org as it's self-contained and folks can easily see the main org as well. seems the cleanest to me. If you make more books, they can each have a specific prefix.

@spier
Copy link
Member Author

spier commented Dec 29, 2020

Thanks for the feedback @markdav-is! I just realized that I got the domain part wrong in my previous comment (fixed now).

So it would be patterns.innersourcecommons.org. Still, short enough I think.

If I may pick your brain on yet another "URL question":
Which of these two URLs for an individual pattern would you prefer?

  1. patterns.innersourcecommons.org/patterns/innersource-portal
  2. patterns.innersourcecommons.org/p/innersource-portal

I am thinking that it would be nice to not repeat the term pattern. So I am leaning to option (2).
But maybe having pattern in the path as well it is actually better for SEO purposes? Not sure :)

@voborgus
Copy link

I will choose the third option if it's possible technically:
patterns.innersourcecommons.org/innersource-portal :)

another point to discuss here: since we're going to a subdomain is it possible to change the design of the git book?
Not for 100% same with the website but at least copy colors and the header.

@spier
Copy link
Member Author

spier commented Jan 25, 2021

Thanks for the feedback @voborgus .

I will choose the third option if it's possible technically:
patterns.innersourcecommons.org/innersource-portal :)

Can you elaborate why this would be your preferred version? Brevity of the URL, or something else?

It would be possible to do this. However it would require us to move all patterns directly into the root of the book, which means that they would be sitting side by side with the Introduction and the Table of Contents. Also if we want to add further pages to the book in the future that aren't patterns, there wouldn't be a natural place for those. For those reasons the patterns are in their own group at the moment.

another point to discuss here: since we're going to a subdomain is it possible to change the design of the git book?
Not for 100% same with the website but at least copy colors and the header.

Would you mind moving the design topic to a separate issue, so that we can keep this issue here focused on the domain?

@voborgus
Copy link

Can you elaborate why this would be your preferred version? Brevity of the URL, or something else?

Yep and the meaning of the URL: go to patterns subdomain and get the pattern with the name specified

But I prefer the easiest possible way to fulfill the task and the short version with /p/ works for me too.

@spier
Copy link
Member Author

spier commented Feb 26, 2021

I am reaching out to @cewilliams about this. Will go for patterns.innersourcecommons.org as a sub-domain.
We can then test later how exactly we want the full URL (incl path) to look like.

This was referenced Feb 28, 2021
@spier
Copy link
Member Author

spier commented Feb 28, 2021

This is fully implemented now. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Self-) Hosting Everything around artifact rendering and presentation.
Projects
None yet
Development

No branches or pull requests

3 participants