Refactor: simplify block_signals function to default enable parameter to True

Author: PierreRaybaut

cdl/core/gui/objectview.py

@@ -215,7 +215,7 @@ def __update_item(
     def populate_tree(self) -> None:
         """Populate tree with objects"""
         uuid = self.get_current_item_id()
-        with block_signals(widget=self, enable=True):
+        with block_signals(widget=self):
             self.clear()
         for group in self.objmodel.get_groups():
             self.add_group_item(group)

cdl/core/gui/plothandler.py

@@ -176,7 +176,7 @@ def add_shapes(self, oid: str, do_autoscale: bool = False) -> None:
                 # Performance optimization: block `plotpy.plot.BasePlot` signals, add
                 # all items except the last one, unblock signals, then add the last one
                 # (this avoids some unnecessary refresh process by PlotPy)
-                with block_signals(self.plot, True):
+                with block_signals(self.plot):
                     with create_progress_bar(
                         self.panel, _("Creating geometric shapes"), max_=len(items) - 1
                     ) as progress:

cdl/utils/qthelpers.py

@@ -415,9 +415,21 @@ def save_restore_stds() -> Generator[None, None, None]:
 
 
 @contextmanager
-def block_signals(widget: QW.QWidget, enable: bool) -> Generator[None, None, None]:
+def block_signals(
+    widget: QW.QWidget, enable: bool = True
+) -> Generator[None, None, None]:
     """Eventually block/unblock widget Qt signals before/after doing some things
-    (enable: True if feature is enabled)"""
+
+    Args:
+        widget: Widget to block/unblock signals
+        enable: Whether to block/unblock signals (default: True). This is useful
+         to avoid blocking signals when not needed without having to handle it by
+         adding an `if` statement which would require to duplicate the code that is
+         inside the `with` statement in the `else` branch.
+
+    Returns:
+        Context manager
+    """
     if enable:
         widget.blockSignals(True)
     try: