Fix: set default signal/image title to file name instead of relative path

Fix #165

Author: PierreRaybaut

CHANGELOG.md

@@ -20,6 +20,7 @@ See DataLab [roadmap page](https://datalab-platform.com/en/contributing/roadmap.
 * Fixed [Issue #162](https://github.com./DataLab-Platform/DataLab/issues/162) - View in a new window: when displaying multiple images, the item list panel should be visible
 * Fixed [Issue #163](https://github.com./DataLab-Platform/DataLab/issues/163) - Open from directory: expected one group per folder when loading multiple files
 * Fixed [Issue #164](https://github.com./DataLab-Platform/DataLab/issues/164) - Open from directory: unsupported files should be ignored when loading files recursively, to avoid warning popup dialog boxes
+* Fixed [Issue #165](https://github.com./DataLab-Platform/DataLab/issues/165) - When opening a file, the default signal/image title must be set to the file name, instead of the relative path to the file name
 
 ## DataLab Version 0.19.0 ##
 

cdl/core/gui/panel/base.py

@@ -875,7 +875,6 @@ def __load_from_file(
             # Create a new group if more than one object is loaded
             group_id = self.add_group(osp.basename(filename)).uuid
         for obj in objs:
-            obj.metadata["source"] = filename
             if add_objects:
                 self.add_object(obj, group_id=group_id, set_current=obj is objs[-1])
         self.selection_changed()

cdl/core/io/image/base.py

@@ -7,14 +7,14 @@
 from __future__ import annotations
 
 import abc
+import os.path as osp
 
 import numpy as np
 
 from cdl.config import _
 from cdl.core.io.base import BaseIORegistry, FormatBase
 from cdl.core.model.image import ImageObj, create_image
 from cdl.utils.qthelpers import CallbackWorker
-from cdl.utils.strings import reduce_path
 
 
 class ImageIORegistry(BaseIORegistry):
@@ -43,10 +43,10 @@ def create_object(filename: str, index: int | None = None) -> ImageObj:
         Returns:
             Image object
         """
-        name = reduce_path(filename)
+        name = osp.basename(filename)
         if index is not None:
             name += f" {index:02d}"
-        return create_image(name)
+        return create_image(name, metadata={"source": filename})
 
     def read(
         self, filename: str, worker: CallbackWorker | None = None

cdl/core/io/signal/base.py

@@ -9,14 +9,14 @@
 from __future__ import annotations
 
 import abc
+import os.path as osp
 
 import numpy as np
 
 from cdl.config import _
 from cdl.core.io.base import BaseIORegistry, FormatBase
 from cdl.core.model.signal import SignalObj, create_signal
 from cdl.utils.qthelpers import CallbackWorker
-from cdl.utils.strings import reduce_path
 
 
 class SignalIORegistry(BaseIORegistry):
@@ -47,10 +47,10 @@ def create_object(filename: str, index: int | None = None) -> SignalObj:
         Returns:
             Signal object
         """
-        name = reduce_path(filename)
+        name = osp.basename(filename)
         if index is not None:
             name += f" {index:02d}"
-        return create_signal(name)
+        return create_signal(name, metadata={"source": filename})
 
     def create_signal(
         self, xydata: np.ndarray, filename: str, index: int | None = None

doc/locale/fr/LC_MESSAGES/contributing/changelog.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: DataLab \n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-04-08 10:22+0200\n"
+"POT-Creation-Date: 2025-04-08 11:05+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language: fr\n"
@@ -69,9 +69,11 @@ msgstr "Correction de l'[Issue #162](https://github.com./DataLab-Platform/DataLab
 msgid "Fixed [Issue #163](https://github.com./DataLab-Platform/DataLab/issues/163) - Open from directory: expected one group per folder when loading multiple files"
 msgstr "Ceci corrige l'[Issue #163](https://github.com./DataLab-Platform/DataLab/issues/163) - Ouvrir depuis le répertoire : un groupe par dossier attendu lors du chargement de plusieurs fichiers"
 
-#, fuzzy
 msgid "Fixed [Issue #164](https://github.com./DataLab-Platform/DataLab/issues/164) - Open from directory: unsupported files should be ignored when loading files recursively, to avoid warning popup dialog boxes"
-msgstr "Ceci corrige l'[Issue #163](https://github.com./DataLab-Platform/DataLab/issues/163) - Ouvrir depuis le répertoire : un groupe par dossier attendu lors du chargement de plusieurs fichiers"
+msgstr "Ceci corrige l'[Issue #164](https://github.com./DataLab-Platform/DataLab/issues/164) - Ouvrir depuis le répertoire : les fichiers non pris en charge doivent être ignorés lors du chargement de fichiers de manière récursive, pour éviter les boîtes de dialogue d'avertissement"
+
+msgid "Fixed [Issue #165](https://github.com./DataLab-Platform/DataLab/issues/165) - When opening a file, the default signal/image title must be set to the file name, instead of the relative path to the file name"
+msgstr "Correction de l'[Issue #165](https://github.com./DataLab-Platform/DataLab/issues/165) - Lors de l'ouverture d'un fichier, le titre par défaut du signal/image doit être défini sur le nom du fichier, au lieu du chemin relatif au nom du fichier"
 
 msgid "DataLab Version 0.19.0"
 msgstr "DataLab Version 0.19.0"
@@ -2212,4 +2214,3 @@ msgstr "Symétrie (verticale/horizontale)"
 
 msgid "Console: added configurable external editor (default: VSCode) to follow the traceback links to the source code"
 msgstr "Console : ajout d'un éditeur externe configurable (par défaut : VSCode) pour suivre les liens de poursuite vers le code source"
-