Fix plot refresh behavior when pasting/deleting metadata to ensure all items are updated, including hidden ones

Fix #122
Fix #123

Author: PierreRaybaut

cdl/core/gui/panel/base.py

@@ -524,7 +524,10 @@ def paste_metadata(self) -> None:
         sel_objects = self.objview.get_sel_objects(include_groups=True)
         for obj in sorted(sel_objects, key=lambda obj: obj.short_id, reverse=True):
             obj.metadata.update(self.__metadata_clipboard)
-        self.SIG_REFRESH_PLOT.emit("existing", True)
+        # We have to do a manual refresh in order to force the plot handler to update
+        # all plot items, even the ones that are not visible (otherwise, image masks
+        # would not be updated after pasting the metadata: see issue #123)
+        self.manual_refresh()
 
     def remove_object(self, force: bool = False) -> None:
         """Remove signal/image object
@@ -615,7 +618,11 @@ def delete_metadata(
             if index == 0:
                 self.selection_changed()
         if refresh_plot:
-            self.SIG_REFRESH_PLOT.emit("existing", True)
+            # We have to do a manual refresh in order to force the plot handler to
+            # update all plot items, even the ones that are not visible (otherwise,
+            # image masks would remained visible after deleting the ROI for example:
+            # see issue #122)
+            self.manual_refresh()
 
     def add_annotations_from_items(
         self, items: list, refresh_plot: bool = True

cdl/core/gui/plothandler.py

@@ -295,7 +295,10 @@ def refresh_plot(
              If False, only show the items (do not update them, except if the
              option "Use reference item LUT range" is enabled and more than one
              item is selected). Defaults to True.
-            force: if True, force refresh even if auto refresh is disabled.
+            force: if True, force refresh even if auto refresh is disabled,
+             and refresh all items associated to objects (even the hidden ones, e.g.
+             when selecting multiple images of the same size and position). Defaults
+             to False.
 
         Raises:
             ValueError: if `what` is not a valid value
@@ -341,7 +344,7 @@ def refresh_plot(
         scales_dict = {}
 
         if oids:
-            if what != "existing":
+            if what != "existing" and not force:
                 oids = self.reduce_shown_oids(oids)
             ref_item = None
             with create_progress_bar(