Skip to content

Commit 9b22bc5

Browse files
stliusaragluna
andauthored
remove module-info, The Spring Framework 5.x does not support module-info (#27254)
* remove module-info, The Spring Framework 5.x does not support module-info.java in their libraries. We want to align this in our Spring implementations. spring-projects/spring-framework#18079 * remove surefire plugin java modules proeprties from pom.xml Co-authored-by: Xiaolu Dai <[email protected]>
1 parent 1208566 commit 9b22bc5

File tree

6 files changed

+0
-127
lines changed

6 files changed

+0
-127
lines changed

sdk/spring/spring-cloud-azure-core/pom.xml

-18
Original file line numberDiff line numberDiff line change
@@ -32,24 +32,6 @@
3232
<url>https://github.com./Azure/azure-sdk-for-java/issues</url>
3333
</issueManagement>
3434

35-
36-
<properties>
37-
<!-- Configures the Java 9+ run to perform the required module exports, opens, and reads that are necessary for testing but shouldn't be part of the module-info. -->
38-
<!-- https://issues.apache.org/jira/browse/SUREFIRE-1563 -->
39-
<javaModulesSurefireArgLine>
40-
--add-modules com.azure.storage.blob
41-
--add-modules com.azure.storage.file.share
42-
--add-modules com.azure.storage.internal.avro
43-
--add-opens com.azure.spring.core/com.azure.spring.core.credential=ALL-UNNAMED
44-
--add-opens com.azure.spring.core/com.azure.spring.core.factory=ALL-UNNAMED
45-
--add-opens com.azure.spring.core/com.azure.spring.core.implementation.connectionstring=ALL-UNNAMED
46-
--add-opens com.azure.spring.core/com.azure.spring.core.implementation.credential.resolver=ALL-UNNAMED
47-
--add-opens com.azure.spring.core/com.azure.spring.core.resource=ALL-UNNAMED
48-
--add-opens com.azure.spring.core/com.azure.spring.core.util=ALL-UNNAMED
49-
--add-opens com.azure.spring.core/com.azure.spring.core=ALL-UNNAMED
50-
</javaModulesSurefireArgLine>
51-
</properties>
52-
5335
<dependencies>
5436
<dependency>
5537
<groupId>org.springframework</groupId>

sdk/spring/spring-cloud-azure-core/src/main/java/module-info.java

-37
This file was deleted.

sdk/spring/spring-cloud-azure-resourcemanager/pom.xml

-8
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,6 @@
3333
<url>https://github.com./Azure/azure-sdk-for-java/issues</url>
3434
</issueManagement>
3535

36-
<properties>
37-
<javaModulesSurefireArgLine>
38-
--add-opens com.azure.spring.resourcemanager/com.azure.spring.resourcemanager.connectionstring=ALL-UNNAMED
39-
--add-opens com.azure.spring.resourcemanager/com.azure.spring.resourcemanager.provisioning.servicebus=ALL-UNNAMED
40-
--add-opens com.azure.spring.resourcemanager/com.azure.spring.resourcemanager.provisioning.eventhubs=ALL-UNNAMED
41-
--add-opens com.azure.spring.resourcemanager/com.azure.spring.resourcemanager.implementation.crud=ALL-UNNAMED
42-
</javaModulesSurefireArgLine>
43-
</properties>
4436
<dependencies>
4537
<dependency>
4638
<groupId>com.azure.spring</groupId>

sdk/spring/spring-cloud-azure-resourcemanager/src/main/java/module-info.java

-10
This file was deleted.

sdk/spring/spring-cloud-azure-service/pom.xml

-32
Original file line numberDiff line numberDiff line change
@@ -33,38 +33,6 @@
3333
<url>https://github.com./Azure/azure-sdk-for-java/issues</url>
3434
</issueManagement>
3535

36-
<properties>
37-
<javaModulesSurefireArgLine>
38-
--add-modules com.azure.cosmos
39-
--add-modules com.azure.data.appconfiguration
40-
--add-modules com.azure.messaging.eventhubs
41-
--add-modules com.azure.messaging.servicebus
42-
--add-modules com.azure.security.keyvault.certificates
43-
--add-modules com.azure.security.keyvault.secrets
44-
--add-modules com.azure.storage.blob
45-
--add-modules com.azure.storage.file.share
46-
--add-modules com.azure.storage.internal.avro
47-
--add-modules com.azure.storage.queue
48-
--add-opens com.azure.spring.core/com.azure.spring.core.factory=ALL-UNNAMED
49-
--add-opens com.azure.spring.service/com.azure.spring.service.eventhubs=ALL-UNNAMED
50-
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.appconfiguration=ALL-UNNAMED
51-
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.core=ALL-UNNAMED
52-
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.cosmos=ALL-UNNAMED
53-
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.credential=ALL-UNNAMED
54-
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.converter=ALL-UNNAMED
55-
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.eventhubs=ALL-UNNAMED
56-
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.keyvault.certificates=ALL-UNNAMED
57-
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.keyvault.secret=ALL-UNNAMED
58-
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.servicebus.factory=ALL-UNNAMED
59-
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.servicebus=ALL-UNNAMED
60-
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.storage.credential=ALL-UNNAMED
61-
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.storage.blob=ALL-UNNAMED
62-
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.storage.fileshare=ALL-UNNAMED
63-
--add-opens com.azure.spring.service/com.azure.spring.service.implementation.storage.queue=ALL-UNNAMED
64-
--add-opens com.azure.spring.service/com.azure.spring.service.implementation=ALL-UNNAMED
65-
</javaModulesSurefireArgLine>
66-
</properties>
67-
6836
<dependencies>
6937
<dependency>
7038
<groupId>com.azure.spring</groupId>

sdk/spring/spring-cloud-azure-service/src/main/java/module-info.java

-22
This file was deleted.

0 commit comments

Comments
 (0)